Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: build/toolchain/toolchain.gni

Issue 2209713002: Fix compilation with Xcode version of clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change conditional. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/toolchain.gni
diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni
index fbaf48066840ae7f51436e87ff8e52b23091fc4f..0dde8d9f1d1e4b20657f8fedc6224dfee1a64343 100644
--- a/build/toolchain/toolchain.gni
+++ b/build/toolchain/toolchain.gni
@@ -49,7 +49,10 @@ declare_args() {
}
}
-assert(!use_xcode_clang || is_ios,
+# Check target_os here instead of is_ios as this file is loaded for secondary
+# toolchain (host toolchain in particular) but the argument is the same for
+# all toolchains.
+assert(!use_xcode_clang || target_os == "ios",
"Using Xcode's clang is only supported in iOS builds")
# Subdirectory within root_out_dir for shared library files.
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698