Fix compilation with Xcode version of clang.

build/toolchain/toolchain.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Toolchain-related configuration that may be needed outside the context of the
 # toolchain() rules themselves.
 
 import("//build/config/chrome_build.gni")
 
 declare_args() {
@@ skipping 31 matching lines @@
     clang_version = "3.9.0"
 
     if (llvm_force_head_revision) {
       # TODO(hans): Remove after next Clang roll.
       # ToT Clang has a higher version number.
       clang_version = "4.0.0"
     }
   }
 }
 
-assert(!use_xcode_clang || is_ios,
-       "Using Xcode's clang is only supported in iOS builds")
+if (current_toolchain == default_toolchain) {
+  assert(!use_xcode_clang || is_ios,
+         "Using Xcode's clang is only supported in iOS builds")
+}

[Dirk Pranke, 2016/08/03 16:49:50]

This is probably relatively harmless (or even a good thing), but unless we
explicitly set use_xcode_clang=false in toolchain_args(), we'll probably end up
using xcode clang for host binaries as well.

So, this might be a bit clearer if the assert was (!use_xcode_clang ||
target_os=="ios").

[sdefresne, 2016/08/03 17:03:40]

The changes in build/toolchain/mac/BUILD.gn only check use_xcode_clang if
toolchain_os is "ios", so when building for iOS, we use the hermetic version of
clang for host_toolchain and xcode's clang for target toolchains.

I've changed the conditional as I agree it is cleaner.

 
 # Subdirectory within root_out_dir for shared library files.
 # TODO(agrieve): GYP sets this to "lib" for Linux & Android, but this won't work
 #     in GN until support for loadable_module() is added.
 #     See: https://codereview.chromium.org/1236503002/
 shlib_subdir = "."
 
 # Root out dir for shared library files.
 root_shlib_dir = root_out_dir
 if (shlib_subdir != ".") {
@@ skipping 31 matching lines @@
 stamp_description = "STAMP {{output}}"
 copy_description = "COPY {{source}} {{output}}"
 if (host_os == "win") {
   stamp_command = "$python_path gyp-win-tool stamp {{output}}"
   copy_command =
       "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}"
 } else {
   stamp_command = "touch {{output}}"
   copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})"
 }