Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209603003: [DevTools] Remove V8InspectorSessionClient. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove V8InspectorSessionClient. BUG=631162 TBR=pfeldman Committed: https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a Cr-Commit-Position: refs/heads/master@{#409586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -72 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-08-03 15:19:58 UTC) #4
kozy
lgtm
4 years, 4 months ago (2016-08-03 17:35:30 UTC) #7
dgozman
On 2016/08/03 17:35:30, kozyatinskiy wrote: > lgtm Thanks! TBR'ing pfeldman for build.
4 years, 4 months ago (2016-08-03 17:45:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209603003/1
4 years, 4 months ago (2016-08-03 17:45:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 19:13:11 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 19:15:08 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a
Cr-Commit-Position: refs/heads/master@{#409586}

Powered by Google App Engine
This is Rietveld 408576698