Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2209603003: [DevTools] Remove V8InspectorSessionClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index c92b902b0e9b67422c66e77abfe21610c482bb24..087fe335b8344806be73f37c313371bab207c1e4 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -268,6 +268,17 @@ private:
return false;
}
+ void resumeStartup(LocalFrame* frame) override
+ {
+ // If we've paused for createWindow, handle it ourselves.
+ if (quitForCreateWindow())
+ return;
+ // Otherwise, pass to the client (embedded workers do it differently).
+ WebDevToolsAgentImpl* agent = WebLocalFrameImpl::fromFrame(frame)->devToolsAgentImpl();
+ if (agent && agent->client())
+ agent->client()->resumeStartup();
+ }
+
bool m_runningForDebugBreak;
bool m_runningForCreateWindow;
std::unique_ptr<WebDevToolsAgentClient::WebKitClientMessageLoop> m_messageLoop;
@@ -584,16 +595,6 @@ void WebDevToolsAgentImpl::sendProtocolMessage(int sessionId, int callId, const
m_client->sendProtocolMessage(sessionId, callId, response, state);
}
-void WebDevToolsAgentImpl::resumeStartup()
-{
- // If we've paused for createWindow, handle it ourselves.
- if (ClientMessageLoopAdapter::resumeForCreateWindow())
- return;
- // Otherwise, pass to the client (embedded workers do it differently).
- if (m_client)
- m_client->resumeStartup();
-}
-
void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
{
if (m_overlay)
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698