Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h

Issue 2209603003: [DevTools] Remove V8InspectorSessionClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
index fb828cdf87073707a90af9631c917df6c26ba297..0db870e8551800b49c8d80903a3a53101e8283b9 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
@@ -8,7 +8,6 @@
#include "platform/inspector_protocol/Platform.h"
#include "platform/v8_inspector/public/V8InspectorClient.h"
#include "platform/v8_inspector/public/V8InspectorSession.h"
-#include "platform/v8_inspector/public/V8InspectorSessionClient.h"
#include <v8.h>
@@ -24,7 +23,7 @@ class V8Inspector;
class V8HeapProfilerAgent;
class V8ProfilerAgent;
-class SimpleInspector : public V8InspectorClient, V8InspectorSessionClient {
+class SimpleInspector : public V8InspectorClient {
public:
SimpleInspector(v8::Isolate*, v8::Local<v8::Context>);
~SimpleInspector();
@@ -60,10 +59,8 @@ private:
void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override { }
void startRepeatingTimer(double, TimerCallback, void* data) override { }
void cancelTimer(void* data) override { }
-
- // V8InspectorSessionClient
- void resumeStartup() override { }
bool canExecuteScripts(int) override { return true; }
+ void resumeStartup(int) override { }
std::unique_ptr<V8Inspector> m_inspector;
std::unique_ptr<V8InspectorSession> m_session;

Powered by Google App Engine
This is Rietveld 408576698