chrome/browser/resources/settings/settings_page/main_page_behavior.js - Issue 2208333002: MD Settings: Ensure sections are shown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2208333002: MD Settings: Ensure sections are shown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js

diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

index a9a3d1e81a27071a01fda7162818aea5cdd0fa51..e17f8809087f41f54231fe9eb93763c45bb28a29 100644

--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js

+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

@@ -55,9 +55,9 @@ var MainPageBehaviorImpl = {

toggleOtherSectionsHidden_: function(sectionName, hidden) {

var sections = Polymer.dom(this.root).querySelectorAll(

- this.sectionSelector + ':not([section=' + sectionName + '])');

+ this.sectionSelector);

for (var section of sections)

- section.hidden = hidden;

+ section.hidden = hidden && (section.section != sectionName);

Dan Beam 2016/08/04 01:10:27 nit that i didn't bother to previously say: i don'

michaelpg 2016/08/04 01:36:42 i'm really stingy with my parens, which used to be

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »