chrome/browser/ui/website_settings/website_settings.cc - Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CT: Formatting and compilation fixes. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client.cc ('k') | chrome/browser/ui/website_settings/website_settings_unittest.cc » ('j') | net/cert/ct_verify_result.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/website_settings.cc

diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc

index 0fa5f8ff5df8aa0a334e498e0d2af7895840533e..58ba1a0a66c6135e714446a550b1c01d22285672 100644

--- a/chrome/browser/ui/website_settings/website_settings.cc

+++ b/chrome/browser/ui/website_settings/website_settings.cc

@@ -162,8 +162,10 @@ int GetSiteIdentityDetailsMessageByCTInfo(

: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_VERIFIED);

// Any invalid SCT.

- if (CertificateTransparencyStatusMatchAny(sct_verify_statuses,

- net::ct::SCT_STATUS_INVALID))

+ if (CertificateTransparencyStatusMatchAny(

+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_SIGNATURE) ||

+ CertificateTransparencyStatusMatchAny(

+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_TIMESTAMP))

return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_INVALID

: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_INVALID);