chrome/browser/ssl/chrome_security_state_model_client.cc - Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.cc

Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CT: Formatting and compilation fixes. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc ('k') | chrome/browser/ui/website_settings/website_settings.cc » ('j') | net/cert/ct_verify_result.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/chrome_security_state_model_client.cc

diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc

index 6f242a44db8042df8ef6383c673a313d20dbe810..0eebb3ce2de04881c3b94a8fc0ba6e6a510df51c 100644

--- a/chrome/browser/ssl/chrome_security_state_model_client.cc

+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc

@@ -246,8 +246,11 @@ void ChromeSecurityStateModelClient::GetVisibleSecurityState(

ssl.num_unknown_scts,

net::ct::SCT_STATUS_LOG_UNKNOWN);

state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),

- ssl.num_invalid_scts,

- net::ct::SCT_STATUS_INVALID);

+ ssl.num_scts_invalid_signature,

+ net::ct::SCT_STATUS_INVALID_SIGNATURE);

+ state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),

+ ssl.num_scts_invalid_timestamp,

+ net::ct::SCT_STATUS_INVALID_TIMESTAMP);

state->sct_verify_statuses.insert(state->sct_verify_statuses.end(),

ssl.num_valid_scts, net::ct::SCT_STATUS_OK);

state->displayed_mixed_content =