chrome/browser/ui/website_settings/website_settings_unittest.cc - Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CT: Formatting and compilation fixes. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/website_settings.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | net/cert/ct_verify_result.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/website_settings_unittest.cc

diff --git a/chrome/browser/ui/website_settings/website_settings_unittest.cc b/chrome/browser/ui/website_settings/website_settings_unittest.cc

index 6c38587b6a97969f704ee6b1008f699347480968..55a829fbf0715e1c66679165afc6afb458f62b2c 100644

--- a/chrome/browser/ui/website_settings/website_settings_unittest.cc

+++ b/chrome/browser/ui/website_settings/website_settings_unittest.cc

@@ -617,8 +617,10 @@ TEST_F(WebsiteSettingsTest, InvalidSCTs) {

status = SetSSLCipherSuite(status, CR_TLS_RSA_WITH_AES_256_CBC_SHA256);

security_info_.connection_status = status;

- security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);

+ security_info_.sct_verify_statuses.push_back(

+ net::ct::SCT_STATUS_INVALID_TIMESTAMP);

+ security_info_.sct_verify_statuses.push_back(

+ net::ct::SCT_STATUS_INVALID_SIGNATURE);

SetDefaultUIExpectations(mock_ui());

EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));

@@ -705,7 +707,8 @@ TEST_F(WebsiteSettingsTest, UnknownAndInvalidSCTs) {

security_info_.connection_status = status;

security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);

- security_info_.sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);

+ security_info_.sct_verify_statuses.push_back(

+ net::ct::SCT_STATUS_INVALID_SIGNATURE);

SetDefaultUIExpectations(mock_ui());

EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));