Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2207413002: [turbofan] Fix missing bailout for accessors in literals. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix missing bailout for accessors in literals. This adds the missing lazy bailout point when defining accessor pairs within object literals via Runtime::kDefineAccessorPropertyUnchecked. The runtime function in question can indeed trigger a lazy deopt due to a DependentCode::kPrototypeCheckGroup dependency. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-633585 BUG=chromium:633585 Committed: https://crrev.com/667d8ad099f05a1e90c7a43b70af8964ac6ca7a6 Cr-Commit-Position: refs/heads/master@{#38336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -31 lines) Patch
M src/ast/ast.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +7 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-633585.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
Benedikt: PTAL. Jaro: FYI.
4 years, 4 months ago (2016-08-04 09:50:22 UTC) #4
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-04 10:22:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207413002/1
4 years, 4 months ago (2016-08-04 10:23:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 10:25:12 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 10:28:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/667d8ad099f05a1e90c7a43b70af8964ac6ca7a6
Cr-Commit-Position: refs/heads/master@{#38336}

Powered by Google App Engine
This is Rietveld 408576698