Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2206953006: Create a separate src for colorspace tests (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create a separate src for colorspace tests This will allow me to run these tests in sRGB mode, while leaving most of the image tests disabled. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006 Committed: https://skia.googlesource.com/skia/+/b8d1aac87a6e3821c7ed435a17a550e6e87d2044

Patch Set 1 #

Patch Set 2 : Add json #

Patch Set 3 : Adding buildbot_spec.json #

Patch Set 4 : Add jsons #

Patch Set 5 : FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M dm/DM.cpp View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (12 generated)
msarett
4 years, 4 months ago (2016-08-04 14:56:04 UTC) #3
borenet
How will this affect run times on the bots? I'm in the process of writing ...
4 years, 4 months ago (2016-08-04 15:06:22 UTC) #6
msarett
Will have no noticeable effect on runtime. This adds an extra config for 5 (colorImage) ...
4 years, 4 months ago (2016-08-04 15:11:16 UTC) #7
borenet
On 2016/08/04 15:11:16, msarett wrote: > Will have no noticeable effect on runtime. This adds ...
4 years, 4 months ago (2016-08-04 15:14:32 UTC) #8
msarett
Adding Joe. If I make this change, will the new src (colorImages) be uploaded to ...
4 years, 4 months ago (2016-08-04 15:14:34 UTC) #10
msarett
Adding buildbot_spec.json
4 years, 4 months ago (2016-08-04 15:20:10 UTC) #11
borenet
Okay, my CL has landed. Please rebase and apply your dm_flags change here: https://skia.googlesource.com/skia/+/master/infra/bots/recipe_modules/vars/api.py#323
4 years, 4 months ago (2016-08-04 18:12:33 UTC) #12
msarett
Alright I think this looks ready.
4 years, 4 months ago (2016-08-04 18:25:59 UTC) #13
borenet
LGTM but looks like you have an assertion failure.
4 years, 4 months ago (2016-08-04 18:48:50 UTC) #18
msarett
On 2016/08/04 18:48:50, borenet wrote: > LGTM but looks like you have an assertion failure. ...
4 years, 4 months ago (2016-08-04 18:50:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206953006/80001
4 years, 4 months ago (2016-08-04 18:58:32 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:22:10 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b8d1aac87a6e3821c7ed435a17a550e6e87d2044

Powered by Google App Engine
This is Rietveld 408576698