Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: src/core/SkColorSpace.cpp

Issue 2206953006: Create a separate src for colorspace tests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: FIXME Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkColorSpace.cpp
diff --git a/src/core/SkColorSpace.cpp b/src/core/SkColorSpace.cpp
index e7bd4e8111e9f1c727dc2964354349003beb3d72..cb5c8695ee0c02a5c1c3df77ec6dd522b08bbaf2 100644
--- a/src/core/SkColorSpace.cpp
+++ b/src/core/SkColorSpace.cpp
@@ -356,7 +356,9 @@ bool SkColorSpace::Equals(const SkColorSpace* src, const SkColorSpace* dst) {
return (src->fGammaNamed == dst->fGammaNamed) && (src->fToXYZD50 == dst->fToXYZD50);
default:
// If |src| does not have a named gamma, fProfileData should be non-null.
- SkASSERT(false);
+ // FIXME (msarett): We may hit this case on pngs that specify float gammas.
+ // Gamma can be non-standard, but we don't have a profile
+ // to fall back on. What do we do?
return false;
}
}
« no previous file with comments | « infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698