Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2206843003: Disable navigations in the unload handler. (Closed)

Created:
4 years, 4 months ago by lfg
Modified:
4 years, 3 months ago
Reviewers:
Nate Chapin, dcheng
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable navigations in the unload handler. Blink intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VfItzNe3WO0 BUG=613244 Committed: https://crrev.com/8fb70277dba468aac9d2eae51e432d76667a79db Cr-Commit-Position: refs/heads/master@{#414588}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Patch Set 3 : add layouttest #

Total comments: 1

Patch Set 4 : testharness.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/navigation/hash-navigation-in-unload-handler.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.h View 1 2 chunks +4 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 43 (22 generated)
lfg
Please take a look.
4 years, 4 months ago (2016-08-11 15:38:37 UTC) #8
lfg
ping.
4 years, 4 months ago (2016-08-16 22:25:39 UTC) #9
dcheng
https://codereview.chromium.org/2206843003/diff/1/third_party/WebKit/Source/core/loader/NavigationScheduler.h File third_party/WebKit/Source/core/loader/NavigationScheduler.h (right): https://codereview.chromium.org/2206843003/diff/1/third_party/WebKit/Source/core/loader/NavigationScheduler.h#newcode112 third_party/WebKit/Source/core/loader/NavigationScheduler.h:112: class CORE_EXPORT NavigationDisablerForUnload { Can we just use NavigationDisablerForBeforeUnload, ...
4 years, 4 months ago (2016-08-16 22:32:03 UTC) #11
lfg
On 2016/08/16 22:32:03, dcheng wrote: > https://codereview.chromium.org/2206843003/diff/1/third_party/WebKit/Source/core/loader/NavigationScheduler.h > File third_party/WebKit/Source/core/loader/NavigationScheduler.h (right): > > https://codereview.chromium.org/2206843003/diff/1/third_party/WebKit/Source/core/loader/NavigationScheduler.h#newcode112 > ...
4 years, 4 months ago (2016-08-16 22:35:32 UTC) #12
dcheng
On 2016/08/16 22:35:32, lfg wrote: > On 2016/08/16 22:32:03, dcheng wrote: > > > https://codereview.chromium.org/2206843003/diff/1/third_party/WebKit/Source/core/loader/NavigationScheduler.h ...
4 years, 4 months ago (2016-08-16 22:44:46 UTC) #13
lfg
On 2016/08/16 22:44:46, dcheng wrote: > > javascript: URLs are currently synchronously loaded, not scheduled. ...
4 years, 4 months ago (2016-08-23 17:08:38 UTC) #14
lfg
On 2016/08/23 17:08:38, lfg wrote: > In general, I don't think it's a good idea ...
4 years, 4 months ago (2016-08-23 17:31:03 UTC) #17
dcheng
The code change l-g-t-m, but I'm wondering if this is testable?
4 years, 4 months ago (2016-08-24 18:46:08 UTC) #20
lfg
On 2016/08/24 18:46:08, dcheng wrote: > The code change l-g-t-m, but I'm wondering if this ...
4 years, 4 months ago (2016-08-24 18:48:04 UTC) #21
dcheng
On 2016/08/24 18:48:04, lfg wrote: > On 2016/08/24 18:46:08, dcheng wrote: > > The code ...
4 years, 3 months ago (2016-08-24 20:57:38 UTC) #22
lfg
On 2016/08/24 20:57:38, dcheng wrote: > > That feels like it's more about observing the ...
4 years, 3 months ago (2016-08-24 21:11:56 UTC) #23
dcheng
On 2016/08/24 21:11:56, lfg wrote: > On 2016/08/24 20:57:38, dcheng wrote: > > > > ...
4 years, 3 months ago (2016-08-25 03:03:06 UTC) #24
lfg
On 2016/08/25 03:03:06, dcheng wrote: > > Fragment navigations are never scheduled, AFAIK, so I ...
4 years, 3 months ago (2016-08-25 18:41:17 UTC) #27
dcheng
Sorry, one more test question. Also, I think there's a typo in the test name ...
4 years, 3 months ago (2016-08-25 18:51:40 UTC) #28
lfg
On 2016/08/25 18:51:40, dcheng wrote: > Sorry, one more test question. Also, I think there's ...
4 years, 3 months ago (2016-08-25 20:15:45 UTC) #30
dcheng
LGTM
4 years, 3 months ago (2016-08-25 20:42:31 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206843003/60001
4 years, 3 months ago (2016-08-25 21:05:33 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/267925)
4 years, 3 months ago (2016-08-25 22:12:51 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206843003/60001
4 years, 3 months ago (2016-08-25 22:15:37 UTC) #39
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-26 00:09:57 UTC) #41
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 00:13:07 UTC) #43
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8fb70277dba468aac9d2eae51e432d76667a79db
Cr-Commit-Position: refs/heads/master@{#414588}

Powered by Google App Engine
This is Rietveld 408576698