third_party/WebKit/Source/core/frame/History.cpp - Issue 2206843003: Disable navigations in the unload handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/History.cpp

Issue 2206843003: Disable navigations in the unload handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testharness.js Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/History.cpp

diff --git a/third_party/WebKit/Source/core/frame/History.cpp b/third_party/WebKit/Source/core/frame/History.cpp

index dc7802484a843656537fca413322ffe118fa1904..2f53a1724e1926700f2c4a94998bb268ffbf913d 100644

--- a/third_party/WebKit/Source/core/frame/History.cpp

+++ b/third_party/WebKit/Source/core/frame/History.cpp

@@ -176,7 +176,7 @@ void History::go(ExecutionContext* context, int delta)

if (!activeDocument->frame() || !activeDocument->frame()->canNavigate(*m_frame))

return;

- if (!NavigationDisablerForBeforeUnload::isNavigationAllowed())

+ if (!NavigationDisablerForUnload::isNavigationAllowed())

return;

// We intentionally call reload() for the current frame if delta is zero.