Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.h

Issue 2206843003: Disable navigations in the unload handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testharness.js Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/NavigationScheduler.h
diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.h b/third_party/WebKit/Source/core/loader/NavigationScheduler.h
index cc8f867ad94fd39fdb94fce9121e9db99c814a7e..280b1b16b8c64d66a3d50d1924c02d170a579850 100644
--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.h
+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.h
@@ -90,15 +90,15 @@ private:
WebScheduler::NavigatingFrameType m_frameType; // Exists because we can't deref m_frame in destructor.
};
-class NavigationDisablerForBeforeUnload {
- WTF_MAKE_NONCOPYABLE(NavigationDisablerForBeforeUnload);
+class NavigationDisablerForUnload {
+ WTF_MAKE_NONCOPYABLE(NavigationDisablerForUnload);
STACK_ALLOCATED();
public:
- NavigationDisablerForBeforeUnload()
+ NavigationDisablerForUnload()
{
s_navigationDisableCount++;
}
- ~NavigationDisablerForBeforeUnload()
+ ~NavigationDisablerForUnload()
{
ASSERT(s_navigationDisableCount);
s_navigationDisableCount--;
@@ -109,25 +109,6 @@ private:
static unsigned s_navigationDisableCount;
};
-class CORE_EXPORT NavigationCounterForUnload {
- WTF_MAKE_NONCOPYABLE(NavigationCounterForUnload);
- STACK_ALLOCATED();
-public:
- NavigationCounterForUnload()
- {
- s_inUnloadHandler++;
- }
- ~NavigationCounterForUnload()
- {
- DCHECK(s_inUnloadHandler);
- s_inUnloadHandler--;
- }
- static bool inUnloadHandler() { return !!s_inUnloadHandler; }
-
-private:
- static unsigned s_inUnloadHandler;
-};
-
} // namespace blink
#endif // NavigationScheduler_h
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/loader/NavigationScheduler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698