Issue 2206763002: Make sure the `target` parameter has been propagated in GclientFactory.

Issue 2206763002: Make sure the `target` parameter has been propagated in GclientFactory. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke

Modified:
4 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Make sure the `target` parameter has been propagated in GclientFactory. The DrMemory builders are still not on recipes, so they're using the old factory, which isn't passing the target=Release_x64 value along properly, breaking the `generate_build_files` step. R=iannucci@chromium.org BUG=633693 Committed: https://chromium.googlesource.com/chromium/tools/build/+/eeffc455db326d3267ef0d10f2fce6a2dcdeedb6

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	scripts/master/factory/commands.py	View		1 chunk	+1 line, -8 lines	0 comments	Download
	M	scripts/master/factory/gclient_factory.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206763002/1

4 years, 4 months ago (2016-08-02 21:51:09 UTC) #4

commit-bot: I haz the power

4 years, 4 months ago (2016-08-02 21:55:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/eeffc455db326d3267ef...