Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: scripts/master/factory/commands.py

Issue 2206763002: Make sure the `target` parameter has been propagated in GclientFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/factory/gclient_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/commands.py
diff --git a/scripts/master/factory/commands.py b/scripts/master/factory/commands.py
index adf875c80dd5cf58f68814a7254245817e555963..35b2f5ff2a2178725f0275800b7019f8a3ca930f 100644
--- a/scripts/master/factory/commands.py
+++ b/scripts/master/factory/commands.py
@@ -1073,14 +1073,7 @@ class FactoryCommands(object):
if '--compiler=goma' in options or '--compiler=goma-clang' in options:
cmd += ['--goma-dir', self.PathJoin('..', '..', '..', '..', 'goma')]
- # TODO(crbug.com/572694) - I'm not sure why target isn't getting honored
- # here on the chromium.memory.full builders, but the only non-recipe
- # builders left on this waterfall are Release, so this is a safe default.
- # target does get passed correctly on the official builders (which are
- # the other ones still not on recipes). It's probably not worth tracking
- # down what's going on otherwise (better to switch to recipes).
- target = target or 'Release'
-
+ assert(target is not None)
cmd += ['//out/%s' % target]
self._factory.addStep(
« no previous file with comments | « no previous file | scripts/master/factory/gclient_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698