Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: scripts/master/factory/gclient_factory.py

Issue 2206763002: Make sure the `target` parameter has been propagated in GclientFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility classes to generate and manage a BuildFactory to be passed to a 5 """Utility classes to generate and manage a BuildFactory to be passed to a
6 builder dictionary as the 'factory' member, for each builder in c['builders']. 6 builder dictionary as the 'factory' member, for each builder in c['builders'].
7 7
8 Specifically creates a base BuildFactory that will execute a gclient checkout 8 Specifically creates a base BuildFactory that will execute a gclient checkout
9 first.""" 9 first."""
10 10
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 factory_properties.setdefault('gclient_env', {}) 248 factory_properties.setdefault('gclient_env', {})
249 gclient_env = factory_properties['gclient_env'] 249 gclient_env = factory_properties['gclient_env']
250 250
251 # Create the spec for the solutions 251 # Create the spec for the solutions
252 gclient_spec = self.BuildGClientSpec(tests) 252 gclient_spec = self.BuildGClientSpec(tests)
253 253
254 # Initialize the factory with the basic steps. 254 # Initialize the factory with the basic steps.
255 factory = self.BaseFactory(gclient_spec, 255 factory = self.BaseFactory(gclient_spec,
256 factory_properties=factory_properties, 256 factory_properties=factory_properties,
257 slave_type=slave_type, 257 slave_type=slave_type,
258 gclient_deps=gclient_deps, options=options) 258 gclient_deps=gclient_deps, options=options,
259 target=target)
259 260
260 # Optional repository root (default: 'src'). 261 # Optional repository root (default: 'src').
261 repository_root = factory_properties.get('repository_root', 'src') 262 repository_root = factory_properties.get('repository_root', 'src')
262 263
263 # Get the factory command object to create new steps to the factory. 264 # Get the factory command object to create new steps to the factory.
264 factory_cmd_obj = commands.FactoryCommands(factory, target, 265 factory_cmd_obj = commands.FactoryCommands(factory, target,
265 self._build_dir, 266 self._build_dir,
266 self._target_platform, 267 self._target_platform,
267 target_arch, 268 target_arch,
268 repository_root) 269 repository_root)
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 385
385 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect', 386 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect',
386 'TrybotTester', 'TrybotBuilder'): 387 'TrybotTester', 'TrybotBuilder'):
387 factory_cmd_obj.AddApplyIssueStep( 388 factory_cmd_obj.AddApplyIssueStep(
388 timeout=timeout, 389 timeout=timeout,
389 server=config.Master.Master4.code_review_site, 390 server=config.Master.Master4.code_review_site,
390 revision_mapping=self._revision_mapping) 391 revision_mapping=self._revision_mapping)
391 392
392 if not self._nohooks_on_update: 393 if not self._nohooks_on_update:
393 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout, options=options) 394 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout, options=options)
OLDNEW
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698