Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2206663002: Delete SkNinePatch (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Leave empty files #

Patch Set 3 : Keep in gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -361 lines) Patch
M gyp/utils.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D include/utils/SkNinePatch.h View 2 1 chunk +0 lines, -33 lines 0 comments Download
D src/utils/SkNinePatch.cpp View 1 2 1 chunk +0 lines, -327 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (19 generated)
msarett
4 years, 4 months ago (2016-08-02 19:15:35 UTC) #3
reed1
not used by android/google3? If so, lgtm
4 years, 4 months ago (2016-08-02 20:51:37 UTC) #19
msarett
On 2016/08/02 20:51:37, reed1 wrote: > not used by android/google3? If so, lgtm AFAICT, they ...
4 years, 4 months ago (2016-08-02 20:54:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206663002/90001
4 years, 4 months ago (2016-08-02 20:54:15 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:90001) as https://skia.googlesource.com/skia/+/a25f470bc7bef67e7b0486efabf8cbf60a064c9c
4 years, 4 months ago (2016-08-02 20:55:16 UTC) #24
djsollen
4 years, 4 months ago (2016-08-03 13:15:53 UTC) #25
Message was sent while issue was closed.
this breaks the Android build because this header was referenced in
frameworks/base/libs/hwui/utils/NinePatchImpl.cpp:23

Powered by Google App Engine
This is Rietveld 408576698