[MD History] Use proper shadows for cards.

[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/48dce59e6b091073c1f119ac531ccf43349289eb
Cr-Commit-Position: refs/heads/master@{#411284}

[calamity, 2016-08-04 07:58:17]

Description was changed from

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on card parents.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
==========

to

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on card parents.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-08-04 08:10:09]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 08:10:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-08-04 08:10:54]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[commit-bot: I haz the power, 2016-08-04 09:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 09:19:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-08-05 00:16:48]

Code generally looks good. However, patching this in locally I'm seeing a
noticeable performance regression for scrolling on the synced tabs page (but not
on the main page, interestingly).

Can you take a look and see if this can be improved? I doubt we can land it like
this.

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:19: filter: drop-shadow(0
2px 2px rgba(0, 0, 0, .05))
Maybe one day we'll be able to get the same shadows as everyone else:
https://bugs.chromium.org/p/chromium/issues/detail?id=610884

[tsergeant, 2016-08-05 01:21:37]

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/grouped_list.html (right):

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/grouped_list.html:18:
@apply(--card-container-filter);
I just noticed a problem with the grouped list: expanding a domain causes the
#background div to expand dramatically.

[calamity, 2016-08-05 04:01:46]

Description was changed from

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on card parents.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-08-05 04:01:58]

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/grouped_list.html (right):

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/grouped_list.html:18:
@apply(--card-container-filter);
On 2016/08/05 01:21:37, tsergeant wrote:
> I just noticed a problem with the grouped list: expanding a domain causes the
> #background div to expand dramatically. 

#background now hidden in embedded mode.

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2206363003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:19: filter: drop-shadow(0
2px 2px rgba(0, 0, 0, .05))
On 2016/08/05 00:16:48, tsergeant wrote:
> Maybe one day we'll be able to get the same shadows as everyone else:
> https://bugs.chromium.org/p/chromium/issues/detail?id=610884

They don't even render the same T_T

Changed the badly performing pages to box shadow which match the downloads page,
but had to change the drop shadow to match. The same values result in different
shadows so I've eyeballed something that looks similar.

[tsergeant, 2016-08-08 00:24:54]

lgtm

https://codereview.chromium.org/2206363003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2206363003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_list_test.js:191: element.scrollTop =
100;
Nit: Maybe do scrollToIndex
(https://github.com/PolymerElements/iron-list/blob/4713a5dc86da222167e3467531a...)
here?

[calamity, 2016-08-10 04:57:48]

Patchset #3 (id:40001) has been deleted

[calamity, 2016-08-10 04:59:38]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[calamity, 2016-08-10 04:59:39]

+dbeam for cr_shared_menu.js OWNERS.

https://codereview.chromium.org/2206363003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2206363003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_list_test.js:191: element.scrollTop =
100;
On 2016/08/08 00:24:53, tsergeant wrote:
> Nit: Maybe do scrollToIndex
>
(https://github.com/PolymerElements/iron-list/blob/4713a5dc86da222167e3467531a...)
> here?

Done.

[calamity, 2016-08-10 05:24:38]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:25:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 06:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 06:00:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2016-08-10 22:38:07]

lgtm

https://codereview.chromium.org/2206363003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2206363003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_style.html:14: drop-shadow(0 1px 1px
rgba(0, 0, 0, .2));
my brain popped

[calamity, 2016-08-11 05:46:16]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 05:46:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 07:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 07:32:40]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-08-11 07:37:05]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-08-11 07:37:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2206363003/#ps80001
(title: "address comment, fix test")

[commit-bot: I haz the power, 2016-08-11 07:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 07:42:21]

Description was changed from

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-11 07:42:23]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-11 07:43:55]

Description was changed from

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use proper shadows for cards.

This CL adds proper shadows to the MD History cards in all views by
adding a drop shadow filter on the history-list and box shadows on
the history-grouped-list and synced-device-card.

In order to prevent the scrollbars from rendering shadows, the scroll
behavior of the history-list has been changed to use the iron list
as a scroll target.

A background div has been added to each history-item which is 1px
taller than the actual item in order to cover the shadow that renders
beneath the next item which shows through at non-integer zoom levels.

BUG=616676
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/48dce59e6b091073c1f119ac531ccf43349289eb
Cr-Commit-Position: refs/heads/master@{#411284}
==========

[commit-bot: I haz the power, 2016-08-11 07:43:56]

Patchset 4 (id:??) landed as
https://crrev.com/48dce59e6b091073c1f119ac531ccf43349289eb
Cr-Commit-Position: refs/heads/master@{#411284}