Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2206873002: [MD History] Fix border radius on history items. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Fix border radius on history items. This CL fixes an issue where every history item was getting a border radius which breaks the card illusion since only the top of the card and bottom of the card should get border radii. BUG=425625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e27f96e0d2b934326e043c294550ba99e0a0fd62 Cr-Commit-Position: refs/heads/master@{#409725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/resources/md_history/history_item.html View 2 chunks +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
calamity
4 years, 4 months ago (2016-08-03 06:01:17 UTC) #3
tsergeant
lgtm
4 years, 4 months ago (2016-08-03 07:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206873002/1
4 years, 4 months ago (2016-08-04 05:11:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 06:02:38 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 06:04:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27f96e0d2b934326e043c294550ba99e0a0fd62
Cr-Commit-Position: refs/heads/master@{#409725}

Powered by Google App Engine
This is Rietveld 408576698