[MD History] Add shift-selection to the history lists.

[MD History] Add shift-selection to the history lists.

This CL adds the ability to select multiple items in history-list and
grouped-history-list by shift-clicking. The selectedPaths array in
HistoryListBehavior has been changed to a Set and the toolbar's selection
count has been hooked up to the selectedPaths set's size.

BUG=589363
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e3bca2a4f22d59e6e19d6d6b1845a0140967cfa
Cr-Commit-Position: refs/heads/master@{#412180}

[calamity, 2016-08-11 05:38:56]

Description was changed from

==========
[MD History] Add shift-selection to the history lists.

This CL adds the ability to select multiple items in history-list and
grouped-history-list by shift-clicking. The selectedPaths array in
HistoryListBehavior has been changed to a Set and the toolbar's selection
count has been hooked up to the selectedPaths set's size.

BUG=589363
==========

to

==========
[MD History] Add shift-selection to the history lists.

This CL adds the ability to select multiple items in history-list and
grouped-history-list by shift-clicking. The selectedPaths array in
HistoryListBehavior has been changed to a Set and the toolbar's selection
count has been hooked up to the selectedPaths set's size.

BUG=589363
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-08-11 05:52:40]

Patchset #1 (id:1) has been deleted

[calamity, 2016-08-11 07:37:36]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-08-15 04:01:15]

Patchset #2 (id:40001) has been deleted

[tsergeant, 2016-08-15 04:49:50]

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:58: e.preventDefault();
You should probably only preventDefault when shift is pressed.

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (left):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:10: //
listContainer.selectedItem.selectedPaths.length.
This is still relevant, right? There are still cases where it would be nice not
to fire an 'unselect-all' just in case the toolbar needs to be reset.

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:89: getSelectedItemCount:
function() {
/** @return {number} */

https://codereview.chromium.org/2239623002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_grouped_list_test.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:202: });
Nit: \n

[calamity, 2016-08-15 07:07:50]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 07:07:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-08-15 07:18:40]

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:58: e.preventDefault();
On 2016/08/15 04:49:50, tsergeant wrote:
> You should probably only preventDefault when shift is pressed.

Done.

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (left):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:10: //
listContainer.selectedItem.selectedPaths.length.
On 2016/08/15 04:49:50, tsergeant wrote:
> This is still relevant, right? There are still cases where it would be nice
not
> to fire an 'unselect-all' just in case the toolbar needs to be reset.

Hmm. Ok, restored. I'm not convinced there's a nice way to bind this actually...

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:89: getSelectedItemCount:
function() {
On 2016/08/15 04:49:50, tsergeant wrote:
> /** @return {number} */ 

Done.

https://codereview.chromium.org/2239623002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_grouped_list_test.js (right):

https://codereview.chromium.org/2239623002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:202: });
On 2016/08/15 04:49:50, tsergeant wrote:
> Nit: \n

Done.

[calamity, 2016-08-15 07:20:52]

Patchset #3 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-08-15 07:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 07:21:28]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tsergeant, 2016-08-16 01:26:01]

lgtm

https://codereview.chromium.org/2239623002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_history/history_item.js (right):

https://codereview.chromium.org/2239623002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_history/history_item.js:52: /*
/** to fix closure

[tsergeant, 2016-08-16 01:26:28]

On 2016/08/16 01:26:01, tsergeant wrote:
> lgtm
> 
>
https://codereview.chromium.org/2239623002/diff/100001/chrome/browser/resourc...
> File chrome/browser/resources/md_history/history_item.js (right):
> 
>
https://codereview.chromium.org/2239623002/diff/100001/chrome/browser/resourc...
> chrome/browser/resources/md_history/history_item.js:52: /*
> /** to fix closure

And thanks for the comprehensive tests

[calamity, 2016-08-16 03:34:31]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 03:34:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 04:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 04:21:48]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-08-16 06:28:36]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-08-16 06:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2239623002/#ps120001
(title: "rebase, fix closure compile")

[commit-bot: I haz the power, 2016-08-16 06:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 06:32:12]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-08-16 06:33:40]

Description was changed from

==========
[MD History] Add shift-selection to the history lists.

This CL adds the ability to select multiple items in history-list and
grouped-history-list by shift-clicking. The selectedPaths array in
HistoryListBehavior has been changed to a Set and the toolbar's selection
count has been hooked up to the selectedPaths set's size.

BUG=589363
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add shift-selection to the history lists.

This CL adds the ability to select multiple items in history-list and
grouped-history-list by shift-clicking. The selectedPaths array in
HistoryListBehavior has been changed to a Set and the toolbar's selection
count has been hooked up to the selectedPaths set's size.

BUG=589363
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e3bca2a4f22d59e6e19d6d6b1845a0140967cfa
Cr-Commit-Position: refs/heads/master@{#412180}
==========

[commit-bot: I haz the power, 2016-08-16 06:33:41]

Patchset 4 (id:??) landed as
https://crrev.com/1e3bca2a4f22d59e6e19d6d6b1845a0140967cfa
Cr-Commit-Position: refs/heads/master@{#412180}