Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 220593010: MSE: Allow requesting coded frame processor: legacy or new (Closed)

Created:
6 years, 8 months ago by wolenetz
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, philipj_slow, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink
Visibility:
Public.

Description

MSE: Allow requesting coded frame processor: legacy or new Updates WebMediaSource to have an addSourceBuffer() version that allows caller to request which of LegacyFrameProcessor or a (not yet landed in Chromium) new frame processor to use to process frames parsed during appends to the source buffer. The choice of which frame processor to request is based on --enable-experimental-web-platform-features, as exposed through RuntimeEnabledFeatures::mediaSourceExperimentalEnabled(): if enabled, the new frame processor is requested. Otherwise, LegacyFrameProcessor is requested. Until the updated Chromium side WebMediaSourceImpl lands and (later) the new Chromium frame processor lands, LegacyFrameProcessor will be used regardless of the requested processor. R=acolwell@chromium.org,abarth@chromium.org BUG=249422 TEST=All MediaSource layout tests pass both before and after Chromium side WMSI change is applied locally, and MediaSourceBase logging shows frameProcessorChoice reflects usage (or lack) of cmdline switch --enable-experimental-web-platform-features Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M Source/modules/mediasource/MediaSourceBase.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M public/platform/WebMediaSource.h View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
wolenetz
PTAL @ Patch set 1: acolwell@: everything abarth@: public/platform/* This is the first of a ...
6 years, 8 months ago (2014-04-02 01:38:40 UTC) #1
abarth-chromium
public/ LGTM
6 years, 8 months ago (2014-04-02 05:47:18 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-02 17:15:32 UTC) #3
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 8 months ago (2014-04-02 17:23:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220593010/1
6 years, 8 months ago (2014-04-02 17:23:18 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 18:32:18 UTC) #6
Message was sent while issue was closed.
Change committed as 170678

Powered by Google App Engine
This is Rietveld 408576698