Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 220123011: MSE: Remove old WebMediaSource::addSourceBuffer declaration (Closed)

Created:
6 years, 8 months ago by wolenetz
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, philipj_slow, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink
Visibility:
Public.

Description

MSE: Remove old WebMediaSource::addSourceBuffer declaration Now that both MediaSourceBase and Chromium WebMediaSourceImpl only call or implement the version of WebMediaSource::addSourceBuffer() that includes FrameProcessorChoice, this change removes the old version of this method that did not have FrameProcessorChoice. R=acolwell@chromium.org,abarth@chromium.org BUG=249422 TEST=All MediaSource layout tests pass locally on Linux Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M public/platform/WebMediaSource.h View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
wolenetz
PTAL @ Patch set 1: acolwell@: everything abarth@: public/platform/* This is the third part of ...
6 years, 8 months ago (2014-04-02 01:39:59 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-02 05:47:38 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-02 17:16:34 UTC) #3
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 8 months ago (2014-04-03 18:38:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220123011/1
6 years, 8 months ago (2014-04-03 18:39:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 19:10:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-03 19:10:46 UTC) #7
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 8 months ago (2014-04-03 19:46:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220123011/1
6 years, 8 months ago (2014-04-03 19:46:30 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:19:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-03 20:19:55 UTC) #11
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 8 months ago (2014-04-03 20:26:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220123011/1
6 years, 8 months ago (2014-04-03 20:26:29 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 21:29:45 UTC) #14
Message was sent while issue was closed.
Change committed as 170796

Powered by Google App Engine
This is Rietveld 408576698