MSE: Pick frame processor in ChunkDemuxer::AddId; prepare unit tests to pick processor

MSE: Pick frame processor in ChunkDemuxer::AddId; prepare unit tests to pick processor

In preparation for landing the new FrameProcessor, this change
parameterizes WebMediaSourceImpl::addSourceBuffer() and
ChunkDemuxer::AddId() to select which of legacy or new
processor to use to process frames appended to the source buffer.

This change also parameterizes ChunkDemuxerTests and the MSE subset
of PipelineIntegrationTests to allow testing of both frame processors
in the short term until the new processor has landed and stabilized
enough.

Since the MSE WebSourceBuffer API for Chromium platform in Blink is
not yet stabilized, this change also removes related OVERRIDEs.

R=acolwell@chromium.org
BUG=249422
TEST=All media unittests pass locally on Linux with ChromeOS ffmpeg branding and proprietary codecs enabled, and no local MSE layout test regression

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261485

[wolenetz, 2014-03-31 22:55:59]

PTAL @ patch set 1.
Thanks!

[acolwell GONE FROM CHROMIUM, 2014-04-01 15:55:13]

lgtm. 

You should probably send out the necessary Blink patch and get approval on the
WebMediaSource signature changes before landing. Blink style doesn't tend to
like bool params so you may end up using an enum in that interface.

https://codereview.chromium.org/220113002/diff/20001/media/filters/chunk_demu...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/220113002/diff/20001/media/filters/chunk_demu...
media/filters/chunk_demuxer.cc:1138: DCHECK(use_legacy_frame_processor);
nit: You might want to output a DLOG() message if this is false so that things
won't break when you land the Blink side change. My guess is that change will
have to include a way for the flag to become false to justify adding the method
to the WebMediaSource interface.

[wolenetz, 2014-04-02 01:43:40]

Thanks for comments. I've refactored things a little so:
This (patch set 2) is now the second part of a 3-sided change to introduce
FrameProcessorChoice argument to WebMediaSource::addSourceBuffer().

The first part is Blink: https://codereview.chromium.org/220593010/

And the third part is Blink: https://codereview.chromium.org/220123011

https://codereview.chromium.org/220113002/diff/20001/media/filters/chunk_demu...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/220113002/diff/20001/media/filters/chunk_demu...
media/filters/chunk_demuxer.cc:1138: DCHECK(use_legacy_frame_processor);
On 2014/04/01 15:55:13, acolwell wrote:
> nit: You might want to output a DLOG() message if this is false so that things
> won't break when you land the Blink side change. My guess is that change will
> have to include a way for the flag to become false to justify adding the
method
> to the WebMediaSource interface.

Done.

[wolenetz, 2014-04-02 17:58:54]

acolwell@, I forgot to ask for your l-g-t-m-2 for patch set 2 due to the API
refactoring since your prior l-g-t-m. Please take a look.

Thanks.

[acolwell GONE FROM CHROMIUM, 2014-04-02 18:03:14]

lgtm

https://codereview.chromium.org/220113002/diff/40001/content/renderer/media/w...
File content/renderer/media/webmediasource_impl.cc (right):

https://codereview.chromium.org/220113002/diff/40001/content/renderer/media/w...
content/renderer/media/webmediasource_impl.cc:51: use_legacy_frame_processor =
false;
nit: I would have expected a default of false and the case above to set it to
true just given the naming here.

[wolenetz, 2014-04-02 18:11:22]

Thank you. Landing patch set 3 is now pending landing part 1 and rolling Blink.

https://codereview.chromium.org/220113002/diff/40001/content/renderer/media/w...
File content/renderer/media/webmediasource_impl.cc (right):

https://codereview.chromium.org/220113002/diff/40001/content/renderer/media/w...
content/renderer/media/webmediasource_impl.cc:51: use_legacy_frame_processor =
false;
On 2014/04/02 18:03:15, acolwell wrote:
> nit: I would have expected a default of false and the case above to set it to
> true just given the naming here.

Done.

[wolenetz, 2014-04-02 23:42:40]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-04-02 23:43:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220113002/60001

[commit-bot: I haz the power, 2014-04-03 08:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 08:32:54]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[wolenetz, 2014-04-03 17:15:52]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-04-03 17:16:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wolenetz@chromium.org/220113002/60001

[commit-bot: I haz the power, 2014-04-03 18:31:37]

Change committed as 261485