Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2205823002: Cleanup function names in SpellChecker and TextCheckingHelper (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup function names in SpellChecker and TextCheckingHelper The above classes no longer performs any grammar checking. This patch cleans up their member function names so that one can be clear that the two classes only performs spell checking. BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e Cr-Commit-Position: refs/heads/master@{#409168}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -124 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 3 chunks +4 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 2 chunks +0 lines, -99 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL. https://codereview.chromium.org/2205823002/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h (right): https://codereview.chromium.org/2205823002/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h#newcode104 third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h:104: void markMisspellingsWithTextCheckingHelper(const VisibleSelection&); I wish I could come ...
4 years, 4 months ago (2016-08-02 09:22:54 UTC) #4
yosin_UTC9
lgtm https://codereview.chromium.org/2205823002/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h (right): https://codereview.chromium.org/2205823002/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h#newcode104 third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h:104: void markMisspellingsWithTextCheckingHelper(const VisibleSelection&); On 2016/08/02 at 09:22:54, Xiaocheng ...
4 years, 4 months ago (2016-08-02 09:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205823002/1
4 years, 4 months ago (2016-08-02 10:50:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 10:53:55 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 10:55:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e
Cr-Commit-Position: refs/heads/master@{#409168}

Powered by Google App Engine
This is Rietveld 408576698