third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h - Issue 2205823002: Cleanup function names in SpellChecker and TextCheckingHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2205823002: Cleanup function names in SpellChecker and TextCheckingHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

index 33fd86168e6ab85a88cbcf1e01112cac3606938c..173530b791bd2d0aeb7dd303fc3c85758bbe9b8c 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

@@ -65,8 +65,8 @@ public:

void advanceToNextMisspelling(bool startBeforeSelection = false);

void showSpellingGuessPanel();

void didBeginEditing(Element*);

- void clearMisspellingsAndBadGrammar(const VisibleSelection&);

- void markMisspellingsAndBadGrammar(const VisibleSelection&);

+ void clearMisspellings(const VisibleSelection&);

+ void markMisspellings(const VisibleSelection&);

void respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);

void replaceMisspelledRange(const String&);

void removeSpellingMarkers();

@@ -78,7 +78,7 @@ public:

bool selectionStartHasSpellingMarkerFor(int from, int length) const;

void updateMarkersForWordsAffectedByEditing(bool onlyHandleWordsContainingSelection);

void cancelCheck();

- void chunkAndMarkAllMisspellingsAndBadGrammar(Node*, const EphemeralRange&);

+ void chunkAndMarkAllMisspellings(Node*, const EphemeralRange&);

void requestTextChecking(const Element&);

// Exposed for testing only

@@ -101,7 +101,7 @@ private:

return *m_frame;

}

- void markMisspellings(const VisibleSelection&);

+ void markMisspellingsWithTextCheckingHelper(const VisibleSelection&);

Xiaocheng 2016/08/02 09:22:54 I wish I could come up with a better name but didn

yosin_UTC9 2016/08/02 09:34:01 Once we remove all grammar checking code, we might

void markAllMisspellingsInRange(const EphemeralRange& spellingRange);

void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);