Cleanup function names in SpellChecker and TextCheckingHelper

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 47 matching lines @@
     void ignoreSpelling();
     bool isSpellCheckingEnabledInFocusedNode() const;
     bool isSpellCheckingEnabledFor(Node*) const;
     static bool isSpellCheckingEnabledFor(const VisibleSelection&);
     void markMisspellingsAfterLineBreak(const VisibleSelection& wordSelection);
     void markMisspellingsAfterTypingToWord(const VisiblePosition &wordStart, const VisibleSelection& selectionAfterTyping);
     void markAndReplaceFor(SpellCheckRequest*, const Vector<TextCheckingResult>&);
     void advanceToNextMisspelling(bool startBeforeSelection = false);
     void showSpellingGuessPanel();
     void didBeginEditing(Element*);
-    void clearMisspellingsAndBadGrammar(const VisibleSelection&);
-    void markMisspellingsAndBadGrammar(const VisibleSelection&);
+    void clearMisspellings(const VisibleSelection&);
+    void markMisspellings(const VisibleSelection&);
     void respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);
     void replaceMisspelledRange(const String&);
     void removeSpellingMarkers();
     void removeSpellingMarkersUnderWords(const Vector<String>& words);
     void spellCheckAfterBlur();
 
     void didEndEditingOnTextField(Element*);
     bool selectionStartHasMarkerFor(DocumentMarker::MarkerType, int from, int length) const;
     bool selectionStartHasSpellingMarkerFor(int from, int length) const;
     void updateMarkersForWordsAffectedByEditing(bool onlyHandleWordsContainingSelection);
     void cancelCheck();
-    void chunkAndMarkAllMisspellingsAndBadGrammar(Node*, const EphemeralRange&);
+    void chunkAndMarkAllMisspellings(Node*, const EphemeralRange&);
     void requestTextChecking(const Element&);
 
     // Exposed for testing only
     SpellCheckRequester& spellCheckRequester() const { return *m_spellCheckRequester; }
 
     // The leak detector will report leaks should queued requests be posted
     // while it GCs repeatedly, as the requests keep their associated element
     // alive.
     //
     // Hence allow the leak detector to effectively stop the spell checker to
     // ensure leak reporting stability.
     void prepareForLeakDetection();
 
 private:
     explicit SpellChecker(LocalFrame&);
 
     LocalFrame& frame() const
     {
         DCHECK(m_frame);
         return *m_frame;
     }
 
-    void markMisspellings(const VisibleSelection&);
+    void markMisspellingsWithTextCheckingHelper(const VisibleSelection&);

[Xiaocheng, 2016/08/02 09:22:54]

I wish I could come up with a better name but didn't.

What's the different between this function and the public |markMisspellings|
(originally |markMisspellingsAndBadGrammar|)?

[yosin_UTC9, 2016/08/02 09:34:01]

Once we remove all grammar checking code, we might have better idea about
naming.

     void markAllMisspellingsInRange(const EphemeralRange& spellingRange);
     void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
 
     void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
     bool unifiedTextCheckerEnabled() const;
 
     void chunkAndMarkAllMisspellings(const TextCheckingParagraph& fullParagraphToCheck);
 
     Member<LocalFrame> m_frame;
     const Member<SpellCheckRequester> m_spellCheckRequester;
 };
 
 } // namespace blink
 
 #endif // SpellChecker_h