Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: tools/gn/docs/reference.md

Issue 2205693005: Add bundle_deps_filter to create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix value of kBundleDepsFilter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/create_bundle_target_generator.cc ('k') | tools/gn/functions_target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/docs/reference.md
diff --git a/tools/gn/docs/reference.md b/tools/gn/docs/reference.md
index f06b517e5c9f3c48f75710522da9ca1ae6b241f2..9d62a5e861e78cff66f330f4036e7223b3946d71 100644
--- a/tools/gn/docs/reference.md
+++ b/tools/gn/docs/reference.md
@@ -1334,7 +1334,7 @@
}
bundle_data("base_unittests_bundle_data]") {
- sources = [ "test/data" ]
+ sources = [ "test/data" ]
outputs = [
"{{bundle_resources_dir}}/{{source_root_relative_dir}}/" +
"{{source_file_part}}"
@@ -1500,8 +1500,8 @@
```
bundle_root_dir*, bundle_resources_dir*, bundle_executable_dir*,
- bundle_plugins_dir*, deps, data_deps, public_deps, visibility,
- product_type, code_signing_args, code_signing_script,
+ bundle_plugins_dir*, bundle_deps_filter, deps, data_deps, public_deps,
+ visibility, product_type, code_signing_args, code_signing_script,
code_signing_sources, code_signing_outputs
* = required
@@ -4830,6 +4830,40 @@
```
+## **bundle_deps_filter**: [label list] A list of labels that are filtered out.
+
+```
+ A list of target labels.
+
+ This list contains target label patterns that should be filtered out
+ when creating the bundle. Any target matching one of those label will
+ be removed from the dependencies of the create_bundle target.
+
+ This is mostly useful when creating application extension bundle as
+ the application extension has access to runtime resources from the
+ application bundle and thus do not require a second copy.
+
+ See "gn help create_bundle" for more information.
+
+```
+
+### **Example**
+
+```
+ create_bundle("today_extension") {
+ deps = [
+ "//base"
+ ]
+ bundle_root_dir = "$root_out_dir/today_extension.appex"
+ bundle_deps_filter = [
+ # The extension uses //base but does not use any function calling
+ # into third_party/icu and thus does not need the icudtl.dat file.
+ "//third_party/icu:icudata",
+ ]
+ }
+
+
+```
## **include_dirs**: Additional include directories.
```
« no previous file with comments | « tools/gn/create_bundle_target_generator.cc ('k') | tools/gn/functions_target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698