Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/gn/functions_target.cc

Issue 2205693005: Add bundle_deps_filter to create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix value of kBundleDepsFilter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/variables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_target.cc
diff --git a/tools/gn/functions_target.cc b/tools/gn/functions_target.cc
index 8aa7f9319384ebaa7ccdc10d73cf33fe762851a6..b7ee6fb313930b1323eb5fa9314d799ce66db37b 100644
--- a/tools/gn/functions_target.cc
+++ b/tools/gn/functions_target.cc
@@ -279,7 +279,7 @@ const char kBundleData_Help[] =
" }\n"
"\n"
" bundle_data(\"base_unittests_bundle_data]\") {\n"
- " sources = [ \"test/data\" ]\n"
+ " sources = [ \"test/data\" ]\n"
" outputs = [\n"
" \"{{bundle_resources_dir}}/{{source_root_relative_dir}}/\" +\n"
" \"{{source_file_part}}\"\n"
@@ -353,8 +353,8 @@ const char kCreateBundle_Help[] =
"Variables\n"
"\n"
" bundle_root_dir*, bundle_resources_dir*, bundle_executable_dir*,\n"
- " bundle_plugins_dir*, deps, data_deps, public_deps, visibility,\n"
- " product_type, code_signing_args, code_signing_script,\n"
+ " bundle_plugins_dir*, bundle_deps_filter, deps, data_deps, public_deps,\n"
+ " visibility, product_type, code_signing_args, code_signing_script,\n"
" code_signing_sources, code_signing_outputs\n"
" * = required\n"
"\n"
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/variables.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698