Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: tools/gn/create_bundle_target_generator.cc

Issue 2205693005: Add bundle_deps_filter to create_bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix value of kBundleDepsFilter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/create_bundle_target_generator.h ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/create_bundle_target_generator.cc
diff --git a/tools/gn/create_bundle_target_generator.cc b/tools/gn/create_bundle_target_generator.cc
index 99bc4644ff0e2190552b8e02a548cdc77119c631..6cbd96fecdc8ec1f5e694b7cfeaaee6288dc93e3 100644
--- a/tools/gn/create_bundle_target_generator.cc
+++ b/tools/gn/create_bundle_target_generator.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "tools/gn/filesystem_utils.h"
+#include "tools/gn/label_pattern.h"
#include "tools/gn/parse_tree.h"
#include "tools/gn/scope.h"
#include "tools/gn/substitution_type.h"
@@ -54,6 +55,9 @@ void CreateBundleTargetGenerator::DoRun() {
if (!FillCodeSigningArgs())
return;
+
+ if (!FillBundleDepsFilter())
+ return;
}
bool CreateBundleTargetGenerator::FillBundleDir(
@@ -193,3 +197,24 @@ bool CreateBundleTargetGenerator::FillCodeSigningArgs() {
return target_->bundle_data().code_signing_args().Parse(*value, err_);
}
+
+bool CreateBundleTargetGenerator::FillBundleDepsFilter() {
+ const Value* value = scope_->GetValue(variables::kBundleDepsFilter, true);
+ if (!value)
+ return true;
+
+ if (!value->VerifyTypeIs(Value::LIST, err_))
+ return false;
+
+ const SourceDir& current_dir = scope_->GetSourceDir();
+ std::vector<LabelPattern>& bundle_deps_filter =
+ target_->bundle_data().bundle_deps_filter();
+ for (const auto& item : value->list_value()) {
+ bundle_deps_filter.push_back(
+ LabelPattern::GetPattern(current_dir, item, err_));
+ if (err_->has_error())
+ return false;
+ }
+
+ return true;
+}
« no previous file with comments | « tools/gn/create_bundle_target_generator.h ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698