Removing unused string resources to clean up linting.

Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773
Committed: https://crrev.com/25650bfc12d08581cb2d702bf6d638ce9fc42aa5
Cr-Commit-Position: refs/heads/master@{#411455}

[estevenson, 2016-08-02 23:23:24]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2016-08-02 23:23:25]

Removed resources from android_chrome_strings.grd that create a lint warning. I
checked code search for their usage and ensured building/testing works without
them.

[agrieve, 2016-08-03 03:29:08]

lgtm

[agrieve, 2016-08-03 03:29:27]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[estevenson, 2016-08-03 14:39:32]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 14:39:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 15:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 15:12:21]

Dry run: This issue passed the CQ dry run.

[estevenson, 2016-08-09 20:10:58]

Description was changed from

==========
Removing unused string resources to clean up linting.

BUG=621773
==========

to

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.
==========

[estevenson, 2016-08-09 20:54:36]

estevenson@chromium.org changed reviewers:
+ brettw@chromium.org

[estevenson, 2016-08-09 20:54:36]

yfriedman@chromium.org: Please review changes in 
chrome/android/java/strings/android_chrome_strings.grd
chrome/android/BUILD.gn

brettw@chromium.org: Please review changes in
components/new_or_sad_tab_strings.grdp

[brettw, 2016-08-09 23:35:49]

brettw@chromium.org changed reviewers:
+ sdefresne@chromium.org

[brettw, 2016-08-09 23:35:49]

I don't know anything about the new_or_sad_tab_strings file and I don't think it
should be in the root components directory, requiring a relatively root-level
owner review.

Fortunately sdefrense added this file and is conveniently also an owner in this
directory, so I'll let him do it.

[Yaron, 2016-08-10 15:27:56]

On 2016/08/09 23:35:49, brettw (ping on IM after 24h) wrote:
> I don't know anything about the new_or_sad_tab_strings file and I don't think
it
> should be in the root components directory, requiring a relatively root-level
> owner review.
> 
> Fortunately sdefrense added this file and is conveniently also an owner in
this
> directory, so I'll let him do it.

lgtm

I imagine those strings are referenced by the native sad tab page but the
rendering is a bit different on android (uses android views).

[sdefresne, 2016-08-10 20:14:59]

new_or_sad_tab_strings.grdp is in components to be shared with iOS. We should
probably move all those grd/grdp to a subdirectory to components (maybe
components/strings to match the location of the generated file).

lgtm

[estevenson, 2016-08-10 20:16:53]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-08-10 20:16:54]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2205143002/#ps80001
(title: "Remove incorrect UnusedResource warnings + rebase")

[commit-bot: I haz the power, 2016-08-10 20:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:30:23]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estevenson, 2016-08-10 21:35:18]

Description was changed from

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.
==========

to

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=
==========

[estevenson, 2016-08-10 21:39:03]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:39:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-08-10 21:59:45]

Description was changed from

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=
==========

to

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773
==========

[commit-bot: I haz the power, 2016-08-11 01:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:17:18]

Dry run: This issue passed the CQ dry run.

[estevenson, 2016-08-11 19:00:35]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:01:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:50:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pkotwicz, 2016-08-11 22:17:01]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-11 22:17:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, yfriedman@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2205143002/#ps140001
(title: "sad_tab_oom_message is needed for native code + remove another unused
string")

[commit-bot: I haz the power, 2016-08-11 22:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:53:32]

Description was changed from

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773
==========

to

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773
==========

[commit-bot: I haz the power, 2016-08-11 23:53:33]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-11 23:56:44]

Description was changed from

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773
==========

to

==========
Removed unused strings from android_chrome_strings.grd.

Include java/res_template/xml/searchable.xml in lint checking by moving
chrome_public_apk_template_resources to chrome_java deps to fix incorrect
UnusedResource warning.

Remove IDS_SAD_TAB_OOM_MESSAGE when building android since it isn't used.

BUG=621773

Committed: https://crrev.com/25650bfc12d08581cb2d702bf6d638ce9fc42aa5
Cr-Commit-Position: refs/heads/master@{#411455}
==========

[commit-bot: I haz the power, 2016-08-11 23:56:45]

Patchset 8 (id:??) landed as
https://crrev.com/25650bfc12d08581cb2d702bf6d638ce9fc42aa5
Cr-Commit-Position: refs/heads/master@{#411455}