chrome/android/BUILD.gn - Issue 2205143002: Removing unused string resources to clean up linting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 2205143002: Removing unused string resources to clean up linting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sad_tab_oom_message is needed for native code + remove another unused string Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index f4363175e032d5753a0b9f273b141fe6f91b2a63..04355f9d03b827d49444641c8a13081154219806 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -145,6 +145,7 @@ java_strings_grd("chrome_strings_grd") {

android_library("chrome_java") {

deps = [

":chrome_public_apk_manifest",

+ ":chrome_public_apk_template_resources",

"//base:base_java",

"//chrome/android/webapk/libs/client:client_java",

"//chrome/android/webapk/libs/common:common_java",

@@ -549,9 +550,7 @@ chrome_public_apk_tmpl_shared("chrome_public_apk") {

apk_name = "ChromePublic"

shared_libraries = [ ":chrome" ]

- deps = [

- ":chrome_public_apk_template_resources",

- ]

+ deps = []

}

chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {

« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »