Issue 220503002: Revert "Handle direction control in compositor Animations"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220503002: Revert "Handle direction control in compositor Animations" (Closed)

Created:
6 years, 8 months ago by rafaelw

Modified:
6 years, 8 months ago

Reviewers:
a.renevier

CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Handle direction control in compositor Animations" This reverts: https://src.chromium.org/viewvc/blink?revision=170491&view=revision Failed attempt to land two-sided patch. The chromium side broke the blink build and then this patch further broke it after the chromium side was reverted. In the future, please do a three-step commit if that's required to ensure no build breakage. TBR=a.renevier@samsung.com BUG=348071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170503

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -67 lines)			Patch
M	Source/core/animation/CompositorAnimations.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/animation/CompositorAnimations.cpp	View	6 chunks	+77 lines, -28 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsImpl.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsTest.cpp	View	14 chunks	+27 lines, -24 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsTestHelper.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	Source/core/animation/CompositorAnimationsTimingFunctionReverserTest.cpp	View	1 chunk	+85 lines, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/platform/WebAnimation.h	View	3 chunks	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rafaelw

6 years, 8 months ago (2014-04-01 02:06:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r170503 (tree was closed).

Expand Messages | Collapse Messages