Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2204953002: Don't close stdio/stderr when shutting down. (Closed)

Created:
4 years, 4 months ago by floitsch
Modified:
4 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status files. #

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -3 lines) Patch
M runtime/bin/file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
A tests/standalone/io/stdio_implicit_close_script.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download
A tests/standalone/io/stdio_implicit_close_test.dart View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 4 months ago (2016-08-02 15:45:54 UTC) #2
Søren Gjesse
lgtm
4 years, 4 months ago (2016-08-03 06:56:27 UTC) #3
floitsch
4 years, 4 months ago (2016-08-03 13:30:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
873c6e4688f0139df074d4346869266922da5ab6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698