runtime/bin/file_win.cc - Issue 2204953002: Don't close stdio/stderr when shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_win.cc

Issue 2204953002: Don't close stdio/stderr when shutting down. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add comment. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_win.cc

diff --git a/runtime/bin/file_win.cc b/runtime/bin/file_win.cc

index 8d45a177dec65a4935ba03d95d451d29f2cd6868..f487a889b885676dfbb79d73d280ce289b0ed7fa 100644

--- a/runtime/bin/file_win.cc

+++ b/runtime/bin/file_win.cc

@@ -38,7 +38,8 @@ class FileHandle {

File::~File() {

- if (!IsClosed()) {

+ if (!IsClosed() &&

+ handle_->fd() != _fileno(stdout) && handle_->fd() != _fileno(stderr)) {

Close();

}

delete handle_;

« no previous file with comments | « runtime/bin/file_macos.cc ('k') | tests/standalone/io/stdio_implicit_close_script.dart » ('j') | no next file with comments »