runtime/bin/file.cc - Issue 2204953002: Don't close stdio/stderr when shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file.cc

Issue 2204953002: Don't close stdio/stderr when shutting down. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add comment. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file.cc

diff --git a/runtime/bin/file.cc b/runtime/bin/file.cc

index 43e19448ace9e5b943454a54d795b48c6f48a9f4..a3dcd7fcb7cb43f2be388129ebd456c25096c1d4 100644

--- a/runtime/bin/file.cc

+++ b/runtime/bin/file.cc

@@ -113,6 +113,7 @@ void FUNCTION_NAME(File_Exists)(Dart_NativeArguments args) {

void FUNCTION_NAME(File_Close)(Dart_NativeArguments args) {

File* file = GetFile(args);

ASSERT(file != NULL);

+ file->Close();

file->DeleteWeakHandle(Dart_CurrentIsolate());

file->Release();

« no previous file with comments | « no previous file | runtime/bin/file_linux.cc » ('j') | no next file with comments »