Improve error reporting in batch mode.

Improve error reporting in batch mode.

Fixes #78.

BUG=https://github.com/dart-lang/rasta/issues/78
R=kasperl@google.com

Committed: https://github.com/dart-lang/rasta/commit/b00230efa82f6735b8e517f4bb7eb8af14a841c9

[ahe, 2016-08-03 11:12:26]

ahe@google.com changed reviewers:
+ kasperl@google.com

[ahe, 2016-08-03 11:14:22]

Description was changed from

==========
Improve error reporting in batch mode.
==========

to

==========
Improve error reporting in batch mode.

Fixes #78.

BUG=https://github.com/dart-lang/rasta/issues/78
==========

[kasperl, 2016-08-04 11:14:13]

LGTM.

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart
File lib/src/rastask.dart (right):

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart#newcod...
lib/src/rastask.dart:159: for (DiagnosticMessage diagnostic in messages) {
Can messages be empty? Maybe move hasCompileTimeError = true out of the for-in
loop.

[ahe, 2016-08-04 11:32:45]

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart
File lib/src/rastask.dart (right):

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart#newcod...
lib/src/rastask.dart:159: for (DiagnosticMessage diagnostic in messages) {
On 2016/08/04 11:14:13, kasperl wrote:
> Can messages be empty? Maybe move hasCompileTimeError = true out of the for-in
> loop.

I'll address this in a follow-up CL.

[ahe, 2016-08-04 11:54:21]

Description was changed from

==========
Improve error reporting in batch mode.

Fixes #78.

BUG=https://github.com/dart-lang/rasta/issues/78
==========

to

==========
Improve error reporting in batch mode.

Fixes #78.

BUG=https://github.com/dart-lang/rasta/issues/78
R=kasperl@google.com

Committed:
https://github.com/dart-lang/rasta/commit/b00230efa82f6735b8e517f4bb7eb8af14a...
==========

[ahe, 2016-08-04 11:54:22]

Committed patchset #1 (id:1) manually as
b00230efa82f6735b8e517f4bb7eb8af14a841c9 (presubmit successful).

[ahe, 2016-08-04 12:15:32]

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart
File lib/src/rastask.dart (right):

https://codereview.chromium.org/2204943003/diff/1/lib/src/rastask.dart#newcod...
lib/src/rastask.dart:159: for (DiagnosticMessage diagnostic in messages) {
On 2016/08/04 11:32:45, ahe wrote:
> On 2016/08/04 11:14:13, kasperl wrote:
> > Can messages be empty? Maybe move hasCompileTimeError = true out of the
for-in
> > loop.
> 
> I'll address this in a follow-up CL.

Thank you, I've created CL 2213913002 for this.