Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: lib/src/run_batch.dart

Issue 2204943003: Improve error reporting in batch mode. (Closed) Base URL: git@github.com:dart-lang/rasta.git@load_all_libs
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/rastask.dart ('K') | « lib/src/rastask.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/run_batch.dart
diff --git a/lib/src/run_batch.dart b/lib/src/run_batch.dart
index d9b8d9ab58eb767805918613f05a5269b85663b1..02a3f6ce87acd5b69c2bf7254a26e3283beba883 100644
--- a/lib/src/run_batch.dart
+++ b/lib/src/run_batch.dart
@@ -45,8 +45,8 @@ Stream<TestDescription> readTestsFromStream(Stream<List<int>> input) async* {
if (splitPoint < 0) {
print("Skipping garbage in input file: $line");
} else {
- Uri input = Uri.parse(line.substring(0, splitPoint));
- Uri output = Uri.parse(line.substring(splitPoint + 1));
+ Uri input = Uri.base.resolve(line.substring(0, splitPoint));
+ Uri output = Uri.base.resolve(line.substring(splitPoint + 1));
yield new TestDescription(new File.fromUri(input), output: output);
}
}
@@ -83,7 +83,6 @@ class RunBatch extends Rastask {
assert(kernel.isInternalStateConsistent);
count++;
- int failuresBefore = compiler.elementsWithCompileTimeErrors.length;
Uri output = description.output;
output ??= description.uri.resolve("${description.uri.path}.dill");
@@ -108,8 +107,7 @@ class RunBatch extends Rastask {
}
if (batchFromStdin) {
- int failuresAfter = compiler.elementsWithCompileTimeErrors.length;
- if (failuresAfter == failuresBefore) {
+ if (!hasCompileTimeErrors) {
print(">>> TEST OK");
} else {
print(">>> TEST FAIL");
« lib/src/rastask.dart ('K') | « lib/src/rastask.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698