Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2203313002: Generate all imported libraries. (Closed)

Created:
4 years, 4 months ago by ahe
Modified:
4 years, 4 months ago
CC:
rasta-dart+reviews_googlegroups.com, Kevin Millikin (Google)
Base URL:
git@github.com:dart-lang/rasta.git@private_names
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Generate all imported libraries. Fixes #84. BUG=https://github.com/dart-lang/rasta/issues/84 R=kmillikin@google.com Committed: https://github.com/dart-lang/rasta/commit/8276efa5080a59a48b43f840a6b0449ecfedd702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/kernel.dart View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
ahe
4 years, 4 months ago (2016-08-03 09:49:55 UTC) #2
ahe
ping
4 years, 4 months ago (2016-08-04 11:37:51 UTC) #3
Kevin Millikin (Google)
It does LGTM. I've verified that it fixes the issue with missing libraries that are ...
4 years, 4 months ago (2016-08-04 11:48:14 UTC) #5
ahe
4 years, 4 months ago (2016-08-04 11:50:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8276efa5080a59a48b43f840a6b0449ecfedd702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698