Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2204823002: [Android] Move isolate generation into //build/config/android. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move isolate generation into //build/config/android. The instrumentation_test_apk template can't use the isolate generation logic if it stays in //testing/test.gni as doing so would introduce a circular dependency. Android appears to be the only user of the isolate generation logic anyway. BUG=633333 Committed: https://crrev.com/f5e2b6ac5cf0356d4e3fa25d65a6d1dcf4aaa2ad Cr-Commit-Position: refs/heads/master@{#409429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -170 lines) Patch
A + build/android/gn/generate_isolate.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +49 lines, -0 lines 0 comments Download
D testing/generate_isolate.py View 1 chunk +0 lines, -116 lines 0 comments Download
M testing/test.gni View 3 chunks +1 line, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
jbudorick
4 years, 4 months ago (2016-08-02 04:03:44 UTC) #2
agrieve
On 2016/08/02 04:03:44, jbudorick wrote: lgtm. We can always move it again if we ever ...
4 years, 4 months ago (2016-08-02 13:51:12 UTC) #3
jbudorick
On 2016/08/02 13:51:12, agrieve wrote: > On 2016/08/02 04:03:44, jbudorick wrote: > > lgtm. We ...
4 years, 4 months ago (2016-08-02 13:53:25 UTC) #4
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 00:54:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204823002/1
4 years, 4 months ago (2016-08-03 01:01:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 02:02:39 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 02:04:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5e2b6ac5cf0356d4e3fa25d65a6d1dcf4aaa2ad
Cr-Commit-Position: refs/heads/master@{#409429}

Powered by Google App Engine
This is Rietveld 408576698