[Android] Switch instrumentation tests to generated device isolates.

[Android] Switch instrumentation tests to generated device isolates.

BUG=633333
Committed: https://crrev.com/84c77363529b707fe226c440a153810cb6dea30d
Cr-Commit-Position: refs/heads/master@{#410238}

[jbudorick, 2016-08-03 00:20:12]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org, dpranke@chromium.org

[jbudorick, 2016-08-03 00:20:13]

Looked at bundle_data briefly. I don't know enough about its current usage to
evaluate whether it makes sense to expand it to also include device data deps
for Android, but I don't think it's wise to do so only for instrumentation tests
and not gtests and I don't have time to handle the latter at the moment.

In the meantime, this gets rid of the upstream checked-in data dependency
.isolate files. (The swarming ones still exist for now.) After this lands, I'll
do the same for the downstream suites, then rip out the remaining isolate_file
logic in //build/config/android.

[Dirk Pranke, 2016-08-03 01:03:47]

lgtm, except that I don't understand this comment:

On 2016/08/03 00:20:13, jbudorick wrote:
> In the meantime, this gets rid of the upstream checked-in data dependency
> .isolate files. (The swarming ones still exist for now.)

What do you mean by "the swarming ones still exist for now" ?

Are you referring to the .isolate files that were used by GYP builds for
swarming
(in the _run targets)?

[jbudorick, 2016-08-03 01:08:08]

On 2016/08/03 01:03:47, Dirk Pranke wrote:
> lgtm, except that I don't understand this comment:
> 
> On 2016/08/03 00:20:13, jbudorick wrote:
> > In the meantime, this gets rid of the upstream checked-in data dependency
> > .isolate files. (The swarming ones still exist for now.)
> 
> What do you mean by "the swarming ones still exist for now" ?
> 
> Are you referring to the .isolate files that were used by GYP builds for
> swarming
> (in the _run targets)?

Yeah. e.g., chrome_public_test_apk currently has two .isolate files checked into
the repository:
 - //chrome/chrome_public_test_apk.isolate, which described the runtime device
data dependencies
 - //chrome/android/chrome_public_test_apk.isolate, which described to swarming
how to run chrome_public_test_apk

I had forgotten that the latter depends on the former, though. Given that, I'm
just going to remove them in this CL as well.

[Dirk Pranke, 2016-08-03 01:12:29]

okay, sounds good.

[agrieve, 2016-08-03 03:26:10]

lgtm assuming you've looked at the generated .isolate files and sanity checked
them for extraneous entries (which based on the additions to device blacklist,
looks like you have).

[jbudorick, 2016-08-03 14:29:39]

jbudorick@chromium.org changed reviewers:
+ boliu@chromium.org, maruel@chromium.org, rockot@chromium.org,
tedchoc@chromium.org, xunjieli@chromium.org

[jbudorick, 2016-08-03 14:29:40]

ptal for owners:
+boliu for android_webview/
+tedchoc for chrome/ and content/
+xunjieli for cronet
+rockot for mojo
+maruel for deleting .isolates

[Ken Rockot(use gerrit already), 2016-08-03 14:45:41]

lgtm

[xunjieli, 2016-08-03 14:58:44]

lgtm. I also kicked off a run on android_cronet_tester.

[jbudorick, 2016-08-03 14:59:38]

On 2016/08/03 14:58:44, xunjieli wrote:
> lgtm. I also kicked off a run on android_cronet_tester.

ah, thanks!

[boliu, 2016-08-03 15:09:07]

rs lgtm

[jbudorick, 2016-08-05 16:34:31]

tedchoc, maruel: ping

[M-A Ruel, 2016-08-05 16:42:43]

oh sorry. I glanced at the file but mostly rs lgtm as "it looks fine but I can't
comment if it's working or not".

[Ted C, 2016-08-05 23:45:00]

On 2016/08/05 16:42:43, M-A Ruel wrote:
> oh sorry. I glanced at the file but mostly rs lgtm as "it looks fine but I
can't
> comment if it's working or not".

lgtm!

[jbudorick, 2016-08-06 00:01:10]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-08-06 00:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, agrieve@chromium.org, rockot@chromium.org,
boliu@chromium.org, maruel@chromium.org, tedchoc@chromium.org,
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2203073002/#ps80001
(title: "rebase 2")

[commit-bot: I haz the power, 2016-08-06 00:02:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 01:00:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-06 01:01:55]

Description was changed from

==========
[Android] Switch instrumentation tests to generated device isolates.

BUG=633333
==========

to

==========
[Android] Switch instrumentation tests to generated device isolates.

BUG=633333

Committed: https://crrev.com/84c77363529b707fe226c440a153810cb6dea30d
Cr-Commit-Position: refs/heads/master@{#410238}
==========

[commit-bot: I haz the power, 2016-08-06 01:01:57]

Patchset 5 (id:??) landed as
https://crrev.com/84c77363529b707fe226c440a153810cb6dea30d
Cr-Commit-Position: refs/heads/master@{#410238}