Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: testing/test.gni

Issue 2204823002: [Android] Move isolate generation into //build/config/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/generate_isolate.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index 18f4f94c3630b961dd6d7edb580e77d4dd119735..eb386d7777a77d302fa71eaa34178c33fab17f89 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -6,59 +6,6 @@
# TEST SETUP
# ==============================================================================
-template("_gen_isolate") {
- testonly = true
- _runtime_deps_file = "$target_gen_dir/$target_name.runtime_deps"
- group("${target_name}__write_deps") {
- forward_variables_from(invoker,
- [
- "data",
- "data_deps",
- "deps",
- "public_deps",
- ])
- write_runtime_deps = _runtime_deps_file
- }
-
- action(target_name) {
- script = "//testing/generate_isolate.py"
- inputs = [
- _runtime_deps_file,
- ]
- outputs = [
- invoker.output,
- ]
- args = [
- "--output-directory=.",
- "--out-file",
- rebase_path(invoker.output, root_build_dir),
- "--runtime-deps-file",
- rebase_path(_runtime_deps_file, root_build_dir),
- ]
- if (is_android) {
- args += [ "--apply-android-filters" ]
- }
- if (defined(invoker.apply_device_filters) && invoker.apply_device_filters) {
- args += [ "--apply-device-filters" ]
- }
- _assert_no_odd_data =
- defined(invoker.assert_no_odd_data) && invoker.assert_no_odd_data
- if (_assert_no_odd_data) {
- args += [ "--assert-no-odd-data" ]
- }
- if (defined(invoker.command)) {
- _isolate_dir = get_path_info(invoker.output, "dir")
- args += [
- "--command",
- rebase_path(invoker.command, _isolate_dir),
- ]
- }
- deps = [
- ":${invoker.target_name}__write_deps",
- ]
- }
-}
-
# Define a test as an executable (or apk on Android) with the "testonly" flag
# set.
# Variable:
@@ -98,7 +45,7 @@ template("test") {
_target_dir_name = get_label_info(":$target_name", "dir")
_device_isolate_path = "$root_out_dir/gen.runtime/$_target_dir_name/$target_name.device.isolate"
_gen_isolate_target_name = "${target_name}__isolate"
- _gen_isolate(_gen_isolate_target_name) {
+ device_isolate(_gen_isolate_target_name) {
forward_variables_from(invoker,
[
"data",
@@ -108,7 +55,6 @@ template("test") {
])
assert_no_odd_data = !_allow_odd_runtime_deps
output = _device_isolate_path
- apply_device_filters = true
}
}
« no previous file with comments | « testing/generate_isolate.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698