Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: content/test/gpu/page_sets/gpu_process_tests.py

Issue 2203713003: Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/page_sets/gpu_process_tests.py
diff --git a/content/test/gpu/page_sets/gpu_process_tests.py b/content/test/gpu/page_sets/gpu_process_tests.py
index aec5bd3ff8d765c4b2c7006f2ad5a2ec9389172a..87fa7e5136ec0845dcf02fe27de234f696822cd6 100644
--- a/content/test/gpu/page_sets/gpu_process_tests.py
+++ b/content/test/gpu/page_sets/gpu_process_tests.py
@@ -570,37 +570,6 @@
super(NoTransparentVisualsGpuProcessPage, self).Validate(tab, results)
-class OnlyOneWorkaroundSharedPageState(GpuProcessSharedPageState):
- def __init__(self, test, finder_options, story_set):
- super(OnlyOneWorkaroundSharedPageState, self).__init__(
- test, finder_options, story_set)
- options = finder_options.browser_options
- options.AppendExtraBrowserArgs('--disable-gpu-driver-bug-workarounds')
- options.AppendExtraBrowserArgs('--use_gpu_driver_workaround_for_testing')
-
-class OnlyOneWorkaroundPage(gpu_test_base.PageBase):
- def __init__(self, story_set, expectations):
- super(OnlyOneWorkaroundPage, self).__init__(
- url='chrome:gpu',
- name='GpuProcess.only_one_workaround',
- page_set=story_set,
- shared_page_state_class=OnlyOneWorkaroundSharedPageState,
- expectations=expectations)
-
- def Validate(self, tab, results):
- browser_list = tab.EvaluateJavaScript('GetDriverBugWorkarounds()')
- gpu_list = tab.EvaluateJavaScript( \
- 'chrome.gpuBenchmarking.getGpuDriverBugWorkarounds()')
-
- if browser_list != ['use_gpu_driver_workaround_for_testing'] or \
- gpu_list != browser_list:
- print 'Test failed. Printing page contents:'
- print tab.EvaluateJavaScript('document.body.innerHTML')
- raise page_test.Failure('Browser or GPU process lists are not reduced ' \
- 'to only use_gpu_driver_workaround_for_testing ' \
- 'workaround: %s != %s' % (browser_list, gpu_list))
-
-
class GpuProcessTestsStorySet(story_set_module.StorySet):
""" Tests that accelerated content triggers the creation of a GPU process """
@@ -634,8 +603,6 @@
self.AddStory(DriverBugWorkaroundsUponGLRendererPage(self, expectations))
self.AddStory(EqualBugWorkaroundsInBrowserAndGpuProcessPage(self,
expectations))
- self.AddStory(OnlyOneWorkaroundPage(self, expectations))
-
if not is_platform_android:
self.AddStory(SkipGpuProcessPage(self, expectations))
self.AddStory(HasTransparentVisualsGpuProcessPage(self, expectations))
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698