Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2203683002: MD History: Convert synced device collapse icon to a button (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Convert synced device collapse icon to a button This allows the button to be accessed by the keyboard, and adds a title tooltip to the button. Also tweaks the styling of the existing buttons in <history-item> extract common styles and introduce consistent touch targets. BUG=624735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/abdca5808398c3596308ed63dd5ddd2cdbf1382b Cr-Commit-Position: refs/heads/master@{#409741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M chrome/browser/resources/md_history/history_item.html View 2 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.js View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
tsergeant
4 years, 4 months ago (2016-08-02 05:40:36 UTC) #3
calamity
lgtm
4 years, 4 months ago (2016-08-04 06:26:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203683002/1
4 years, 4 months ago (2016-08-04 07:00:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 08:35:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:37:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abdca5808398c3596308ed63dd5ddd2cdbf1382b
Cr-Commit-Position: refs/heads/master@{#409741}

Powered by Google App Engine
This is Rietveld 408576698