Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2204833003: MD History: Add menu to cards on Synced Tabs page (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity, bootyru
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Dirk Pranke, jlklein+watch-closure_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Add menu to cards on Synced Tabs page The menu has two options, 'Open all' and 'Hide for now'. This replaces the existing 'Open All' link at the bottom of the card. BUG=280665, 624358 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58 Cr-Commit-Position: refs/heads/master@{#410304}

Patch Set 1 #

Total comments: 6

Patch Set 2 : calamity@ review #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -53 lines) Patch
M chrome/browser/resources/md_history/browser_service.js View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 1 3 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.js View 1 3 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 1 4 chunks +24 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 2 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tsergeant
4 years, 4 months ago (2016-08-04 00:47:02 UTC) #4
calamity
https://codereview.chromium.org/2204833003/diff/1/chrome/browser/resources/md_history/list_container.html File chrome/browser/resources/md_history/list_container.html (right): https://codereview.chromium.org/2204833003/diff/1/chrome/browser/resources/md_history/list_container.html#newcode34 chrome/browser/resources/md_history/list_container.html:34: } Can we remove this then? https://codereview.chromium.org/2204833003/diff/1/chrome/browser/resources/md_history/synced_device_card.html File chrome/browser/resources/md_history/synced_device_card.html ...
4 years, 4 months ago (2016-08-04 07:30:05 UTC) #5
tsergeant
https://codereview.chromium.org/2204833003/diff/1/chrome/browser/resources/md_history/list_container.html File chrome/browser/resources/md_history/list_container.html (right): https://codereview.chromium.org/2204833003/diff/1/chrome/browser/resources/md_history/list_container.html#newcode34 chrome/browser/resources/md_history/list_container.html:34: } On 2016/08/04 07:30:05, calamity wrote: > Can we ...
4 years, 4 months ago (2016-08-05 02:40:02 UTC) #6
calamity
lgtm
4 years, 4 months ago (2016-08-08 03:53:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204833003/60001
4 years, 4 months ago (2016-08-08 04:13:11 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-08 05:09:13 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ee91629ba3a0e59591bd15f67db068bbc43dec58 Cr-Commit-Position: refs/heads/master@{#410304}
4 years, 4 months ago (2016-08-08 05:11:56 UTC) #13
bootyru
4 years, 4 months ago (2016-08-12 00:28:08 UTC) #15
Message was sent while issue was closed.
<iframe width="640" height="400" src="https://www.youtube.com/embed/07KFD5fGq_4"
frameborder="0" allowfullscreen></iframe>

Powered by Google App Engine
This is Rietveld 408576698