chrome/installer/mac/app/OmahaXMLRequest.m - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/OmahaXMLRequest.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/mac/app/OmahaXMLParser.m ('K') | « chrome/installer/mac/app/OmahaXMLParser.m ('k') | chrome/installer/mac/app/Unpacker.h » ('j') | chrome/installer/mac/app/Unpacker.m » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mac/app/OmahaXMLRequest.m

diff --git a/chrome/installer/mac/app/OmahaXMLRequest.m b/chrome/installer/mac/app/OmahaXMLRequest.m

index 8ade57215c1fa275b7cd97df54dbdd31e22caa4f..0d7f29d2846ed2de49b84f7142801c97e88ce413 100644

--- a/chrome/installer/mac/app/OmahaXMLRequest.m

+++ b/chrome/installer/mac/app/OmahaXMLRequest.m

@@ -23,10 +23,8 @@

// user attributes that Omaha actually looks at. The other parameters are useful

// for logging purposes but otherwise not directly used.

+ (NSXMLDocument*)createXMLRequestBody {

- // TODO: might be a good idea in the future to add a version# for this

- // installer using [[NSBundle mainBundle]

- // objectForInfoDictionaryKey:@"CFBundleShortVersionString"]]

- NSString* protocol = @"3.0";

+ NSString* protocol = [[NSBundle mainBundle]

+ objectForInfoDictionaryKey:@"CFBundleShortVersionString"]];

Sidney San Martín 2016/08/13 12:37:18 I just realized, if we'll always pass "3.0" as the

Anna Zeng 2016/08/16 23:07:39 Done.

NSString* platform = @"mac";

NSString* operatingSystem = [SystemInfo getOSVersion];

« chrome/installer/mac/app/OmahaXMLParser.m ('K') | « chrome/installer/mac/app/OmahaXMLParser.m ('k') | chrome/installer/mac/app/Unpacker.h » ('j') | chrome/installer/mac/app/Unpacker.m » ('J')