Added unpacking step

chrome/installer/mac/app/OmahaXMLRequest.m

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "OmahaXMLRequest.h"
 
 #include "SystemInfo.h"
 
 @implementation OmahaXMLRequest : NSObject
 
 + (NSXMLElement*)createElementWithName:(NSString*)name {
   return [[NSXMLElement alloc] initWithName:name];
 }
 
 + (void)forElement:(NSXMLElement*)element
       AddAttribute:(NSString*)attribute
          WithValue:(NSString*)value {
   [element
       addAttribute:[NSXMLNode attributeWithName:attribute stringValue:value]];
 }
 
 // borisv@ indicated that the OS version, platform, appid, and version are the
 // user attributes that Omaha actually looks at. The other parameters are useful
 // for logging purposes but otherwise not directly used.
 + (NSXMLDocument*)createXMLRequestBody {
-  // TODO: might be a good idea in the future to add a version# for this
-  // installer using [[NSBundle mainBundle]
-  // objectForInfoDictionaryKey:@"CFBundleShortVersionString"]]
-  NSString* protocol = @"3.0";
+  NSString* protocol = [[NSBundle mainBundle]
+    objectForInfoDictionaryKey:@"CFBundleShortVersionString"]];

[Sidney San Martín, 2016/08/13 12:37:18]

I just realized, if we'll always pass "3.0" as the protocol, that's definitely
not the installer app version and hard coding it makes sense.

[Anna Zeng, 2016/08/16 23:07:39]

Done.

 
   NSString* platform = @"mac";
   NSString* operatingSystem = [SystemInfo getOSVersion];
   NSString* architecture = [SystemInfo getArch];
   NSString* plat_arch =
       [NSString stringWithFormat:@"%@_%@", operatingSystem, architecture];
 
   NSString* appid = @"com.google.Chrome";
   NSString* version = @"0.0.0.0";
   NSString* language = @"en-us";
@@ skipping 25 matching lines @@
   NSXMLElement* updateChildChild =
       [OmahaXMLRequest createElementWithName:@"updatecheck"];
   [appChild addChild:updateChildChild];
 
   NSXMLDocument* requestXMLDocument =
       [[NSXMLDocument alloc] initWithRootElement:root];
   return requestXMLDocument;
 }
 
 @end