Added unpacking step

chrome/installer/mac/app/OmahaXMLParser.m

Index: chrome/installer/mac/app/OmahaXMLParser.m
diff --git a/chrome/installer/mac/app/OmahaXMLParser.m b/chrome/installer/mac/app/OmahaXMLParser.m
index 016adb500ff6fc4bb53534baa4776c139f21654f..5c9178f8f2a821336344127ff92aec273503e752 100644
--- a/chrome/installer/mac/app/OmahaXMLParser.m
+++ b/chrome/installer/mac/app/OmahaXMLParser.m
@@ -21,8 +21,6 @@
   [parser setDelegate:omahaParser];
   if (![parser parse]) {
     *error = [parser parserError];
-    // TODO: pass up error object to indicate error occurred so
-    // InstallerWindowController can create custom user error message.
     return nil;
   }
 
@@ -34,6 +32,9 @@
   }
 
   if ([completeDownloadURLs count] < 1) {
+    // TODO: currently whatever error is passed in doesn't matter... we should
+    // make it so that the type of error informs what the installer will do
+    // about the error
     *error = [NSError errorWithDomain:@"ChromeErrorDomain" code:1 userInfo:nil];

[Elly Fong-Jones, 2016/08/16 15:26:18]

what's code 1?

[Anna Zeng, 2016/08/16 23:07:39]

As the newly added TODO indicates: the error created here doesn't matter -- as
long as an error gets passed up to OmahaCommunication, we have been able to
communicate that the parsing did not succeed in getting what we wanted (a usable
URL to download Chrome from). It'd be helpful in the future to have error play a
bigger role in determining what should be done to take care of the error, but
for now it remains a TODO.

     return nil;
   }