chrome/installer/mac/app/Info.plist - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/Info.plist

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolved comments, made many minor changes, ready for review! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/Info.plist

diff --git a/chrome/installer/mac/app/Info.plist b/chrome/installer/mac/app/Info.plist

index c671e4453955843146edbb63683132237a31268a..955f4d342502eaff8062f5c4fd6643691dafd172 100644

--- a/chrome/installer/mac/app/Info.plist

+++ b/chrome/installer/mac/app/Info.plist

@@ -5,7 +5,7 @@

<key>CFBundleDevelopmentRegion</key>

<key>CFBundleExecutable</key>

- <string>$(EXECUTABLE_NAME)</string>

+ <string>mac_installer_app</string>

Sidney San Martín 2016/08/19 22:06:04 I'd probably hold off on changing this until you/I

Anna Zeng 2016/08/23 03:13:43 Done.

<key>CFBundleIconFile</key>

<key>CFBundleIdentifier</key>